Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: tie objects lifetime to the thread they belong to #22242

Merged
merged 0 commits into from
Aug 14, 2018
Merged

inspector: tie objects lifetime to the thread they belong to #22242

merged 0 commits into from
Aug 14, 2018

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 10, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This is needed for #21364

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 10, 2018
@trivikr
Copy link
Member

trivikr commented Aug 12, 2018

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 12, 2018
@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 13, 2018

Fixed Visual C++ compilation.

CI: https://ci.nodejs.org/job/node-test-pull-request/16424/

@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 13, 2018

Windows CI failure is #21425
LinuxOne is an infrastructure issue.

@eugeneo eugeneo closed this Aug 14, 2018
@eugeneo eugeneo deleted the objects_live_in_thread branch August 14, 2018 16:09
@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants