util: make TextEncoder/TextDecoder global #22281

jasnell · 2018-08-12T18:56:13Z

Fixes: #20365

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-08-12T18:56:14Z

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/532/pipeline

vsemozhetbyt · 2018-08-12T19:07:21Z

doc/api/globals.md

@@ -152,6 +152,20 @@ The WHATWG `URL` class. See the [`URL`][] section.
 added: v10.0.0
 -->

+## TextDecoder


Both sections need to be placed before ## URL section, ABC-wise.

vsemozhetbyt · 2018-08-12T19:09:00Z

doc/api/globals.md

+-->
+
+The WHATWG `TextEncoder` class. See the [`TextEncoder`][] section.
+
 <!-- type=global -->

 The WHATWG `URLSearchParams` class. See the [`URLSearchParams`][] section.


Misplaced part of the ## URLSearchParams section.

vsemozhetbyt · 2018-08-12T19:21:14Z

It seems intl.md also needs updating, see require('util').TextDecoder mentions.

jasnell · 2018-08-12T19:22:02Z

@vsemozhetbyt ... wasn't sure if we should update intl.md to be honest.

TimothyGu

LGTM with one nit

TimothyGu · 2018-08-12T20:48:35Z

lib/internal/bootstrap/node.js

+        value: TextEncoder,
+        writable: true,
+        configurable: true,
+        enumerable: true


Per Web IDL the properties should not be enumerable.

ah right... I knew something was off about that. Thx!

BridgeAR

LGTM with the comments addressed.

BridgeAR · 2018-08-13T00:34:35Z

test/common/index.js

-  setTimeout
+  setTimeout,
+  TextDecoder,
+  TextEncoder


This has to be removed again as soon as they are not enumerable anymore.

jasnell · 2018-08-15T22:34:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/16474/

mcollina

Can you please retain a test that check that what is exposed through util is the same of the globals?

jasnell · 2018-09-10T18:26:56Z

Will be updating this PR this week.

Fixes: nodejs#20365

jasnell · 2018-09-12T14:34:46Z

@mcollina ... requested test added!

jasnell · 2018-09-12T14:35:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17148/

mcollina · 2018-09-12T16:17:42Z

Note that this would likely break lab and possibly some other testing frameworks, cc @geek.

mcollina

LGTM

trivikr · 2018-09-15T05:47:04Z

~~Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/17204/~~
~~Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/17209/~~
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17223/

mcollina · 2018-09-17T09:12:40Z

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17228/

addaleax · 2018-09-17T15:14:28Z

Landed in 932be01

Fixes: #20365 PR-URL: #22281 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Notable changes: * Build * FreeBSD 10 is no longer supported. [#22617](#22617) * `child_process` * The default value of the `windowsHide` option has been changed to `true`. [#21316](#21316) * `console` * `console.countReset()` will emit a warning if the timer being reset does not exist. [#21649](#21649) * `console.time()` will no longer reset a timer if it already exists. [#20442](#20442) * `crypto` * PEM-level encryption is now supported. [#23151](#23151) * An API for key pair generation has been added. [#22660](#22660) * Dependencies * V8 has been updated to 7.0. [#22754](#22754) * `fs` * The `fs.read()` method now requires a callback. [#22146](#22146) * The previously deprecated `fs.SyncWriteStream` utility has been removed.[#20735](#20735) * `http` * The `http`, `https`, and `tls` modules now use the WHATWG URL parser by default. [#20270](#20270) * `http2` * An event will be emitted when a `PING` frame is received. [#23009](#23009) * Support for the `ORIGIN` frame has been added. [#22956](#22956) * General * Use of `process.binding()` has been deprecated. Userland code using `process.binding()` should re-evaluate that use and begin migrating. * An experimental implementation of `queueMicrotask()` has been added. [#22951](#22951) * Internal * Windows performance-counter support has been removed. [#22485](#22485) * The `--expose-http2` command-line option has been removed. [#20887](#20887) * Promises * A new `multipleResolves` event will be emitted when a Promise is resolved (or rejected) more than once. [#22218](#22218) * Timers * Interval timers will be rescheduled even if previous interval threw an error. [#20002](#20002) * `util` * The WHATWG `TextEncoder` and `TextDecoder` are now globals. [#22281](#22281) * `util.inspect()` output size is limited to 128 MB by default. [#22756](#22756) * A runtime warning will be emitted when `NODE_DEBUG` is set for either `http` or `http2`. [#21914](#21914)

Notable changes: * Build * FreeBSD 10 is no longer supported.[#22617](#22617) * `child_process` * The default value of the `windowsHide` option has been changed to `true`. [#21316](#21316) * `console` * `console.countReset()` will emit a warning if the timer being reset does not exist. [#21649](#21649) * `console.time()` will no longer reset a timer if it already exists. [#20442](#20442) * Dependencies * V8 has been updated to 7.0. [#22754](#22754) * `fs` * The `fs.read()` method now requires a callback. [#22146](#22146) * The previously deprecated `fs.SyncWriteStream` utility has been removed.[#20735](#20735) * `http` * The `http`, `https`, and `tls` modules now use the WHATWG URL parser by default. [#20270](#20270) * General * Use of `process.binding()` has been deprecated. Userland code using `process.binding()` should re-evaluate that use and begin migrating. If there are no supported API alternatives, please open an issue in the Node.js GitHub repository so that a suitable alternative may be discussed. * An experimental implementation of `queueMicrotask()` has been added. [#22951](#22951) * Internal * Windows performance-counter support has been removed. [#22485](#22485) * The `--expose-http2` command-line option has been removed. [#20887](#20887) * Timers * Interval timers will be rescheduled even if previous interval threw an error. [#20002](#20002) * `util` * The WHATWG `TextEncoder` and `TextDecoder` are now globals. [#22281](#22281) * `util.inspect()` output size is limited to 128 MB by default. [#22756](#22756) * A runtime warning will be emitted when `NODE_DEBUG` is set for either `http` or `http2`. [#21914](#21914)

Notable changes: * Build * FreeBSD 10 is no longer supported.[nodejs#22617](nodejs#22617) * `child_process` * The default value of the `windowsHide` option has been changed to `true`. [nodejs#21316](nodejs#21316) * `console` * `console.countReset()` will emit a warning if the timer being reset does not exist. [nodejs#21649](nodejs#21649) * `console.time()` will no longer reset a timer if it already exists. [nodejs#20442](nodejs#20442) * Dependencies * V8 has been updated to 7.0. [nodejs#22754](nodejs#22754) * `fs` * The `fs.read()` method now requires a callback. [nodejs#22146](nodejs#22146) * The previously deprecated `fs.SyncWriteStream` utility has been removed.[nodejs#20735](nodejs#20735) * `http` * The `http`, `https`, and `tls` modules now use the WHATWG URL parser by default. [nodejs#20270](nodejs#20270) * General * Use of `process.binding()` has been deprecated. Userland code using `process.binding()` should re-evaluate that use and begin migrating. If there are no supported API alternatives, please open an issue in the Node.js GitHub repository so that a suitable alternative may be discussed. * An experimental implementation of `queueMicrotask()` has been added. [nodejs#22951](nodejs#22951) * Internal * Windows performance-counter support has been removed. [nodejs#22485](nodejs#22485) * The `--expose-http2` command-line option has been removed. [nodejs#20887](nodejs#20887) * Timers * Interval timers will be rescheduled even if previous interval threw an error. [nodejs#20002](nodejs#20002) * `util` * The WHATWG `TextEncoder` and `TextDecoder` are now globals. [nodejs#22281](nodejs#22281) * `util.inspect()` output size is limited to 128 MB by default. [nodejs#22756](nodejs#22756) * A runtime warning will be emitted when `NODE_DEBUG` is set for either `http` or `http2`. [nodejs#21914](nodejs#21914)

Notable changes: * Build * FreeBSD 10 is no longer supported.[#22617](nodejs/node#22617) * `child_process` * The default value of the `windowsHide` option has been changed to `true`. [#21316](nodejs/node#21316) * `console` * `console.countReset()` will emit a warning if the timer being reset does not exist. [#21649](nodejs/node#21649) * `console.time()` will no longer reset a timer if it already exists. [#20442](nodejs/node#20442) * Dependencies * V8 has been updated to 7.0. [#22754](nodejs/node#22754) * `fs` * The `fs.read()` method now requires a callback. [#22146](nodejs/node#22146) * The previously deprecated `fs.SyncWriteStream` utility has been removed.[#20735](nodejs/node#20735) * `http` * The `http`, `https`, and `tls` modules now use the WHATWG URL parser by default. [#20270](nodejs/node#20270) * General * Use of `process.binding()` has been deprecated. Userland code using `process.binding()` should re-evaluate that use and begin migrating. If there are no supported API alternatives, please open an issue in the Node.js GitHub repository so that a suitable alternative may be discussed. * An experimental implementation of `queueMicrotask()` has been added. [#22951](nodejs/node#22951) * Internal * Windows performance-counter support has been removed. [#22485](nodejs/node#22485) * The `--expose-http2` command-line option has been removed. [#20887](nodejs/node#20887) * Timers * Interval timers will be rescheduled even if previous interval threw an error. [#20002](nodejs/node#20002) * `util` * The WHATWG `TextEncoder` and `TextDecoder` are now globals. [#22281](nodejs/node#22281) * `util.inspect()` output size is limited to 128 MB by default. [#22756](nodejs/node#22756) * A runtime warning will be emitted when `NODE_DEBUG` is set for either `http` or `http2`. [#21914](nodejs/node#21914)

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 12, 2018

devsnek approved these changes Aug 12, 2018

View reviewed changes

vsemozhetbyt added i18n-api Issues and PRs related to the i18n implementation. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. labels Aug 12, 2018

vsemozhetbyt reviewed Aug 12, 2018

View reviewed changes

gdams force-pushed the master branch from e4bbfda to d3d5982 Compare August 12, 2018 19:22

TimothyGu approved these changes Aug 12, 2018

View reviewed changes

BridgeAR added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Aug 13, 2018

BridgeAR requested a review from a team August 13, 2018 00:32

BridgeAR removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Aug 13, 2018

BridgeAR approved these changes Aug 13, 2018

View reviewed changes

jasnell force-pushed the global-textencoder-textdecoder branch from 02c6a27 to 0e437e1 Compare August 15, 2018 22:49

TimothyGu approved these changes Aug 15, 2018

View reviewed changes

mcollina reviewed Aug 16, 2018

View reviewed changes

joyeecheung mentioned this pull request Aug 17, 2018

CI Failures: 20180817 nodejs/reliability#14

Closed

util: make TextEncoder/TextDecoder global

75f1128

Fixes: nodejs#20365

jasnell force-pushed the global-textencoder-textdecoder branch from 0e437e1 to 75f1128 Compare September 12, 2018 14:34

mcollina approved these changes Sep 12, 2018

View reviewed changes

cjihrig approved these changes Sep 13, 2018

View reviewed changes

thefourtheye approved these changes Sep 17, 2018

View reviewed changes

mcollina added the needs-ci PRs that need a full CI run. label Sep 17, 2018

addaleax removed the needs-ci PRs that need a full CI run. label Sep 17, 2018

addaleax closed this Sep 17, 2018

MarkTiedemann mentioned this pull request Sep 17, 2018

util: expose the WHATWG Encoding API globally #20662

Closed

4 tasks

jasnell mentioned this pull request Oct 2, 2018

11.0.0 proposal #23230

Closed

4 tasks

okofish mentioned this pull request Nov 2, 2018

Make osc.readString not fail on very large strings colinbdclark/osc.js#92

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: make TextEncoder/TextDecoder global #22281

util: make TextEncoder/TextDecoder global #22281

jasnell commented Aug 12, 2018

nodejs-github-bot commented Aug 12, 2018

vsemozhetbyt Aug 12, 2018

vsemozhetbyt Aug 12, 2018

vsemozhetbyt commented Aug 12, 2018

jasnell commented Aug 12, 2018

TimothyGu left a comment

TimothyGu Aug 12, 2018

jasnell Aug 15, 2018

BridgeAR left a comment

BridgeAR Aug 13, 2018

jasnell commented Aug 15, 2018

mcollina left a comment

jasnell commented Sep 10, 2018

jasnell commented Sep 12, 2018

jasnell commented Sep 12, 2018

mcollina commented Sep 12, 2018

mcollina left a comment

trivikr commented Sep 15, 2018 •

edited

Loading

mcollina commented Sep 17, 2018

addaleax commented Sep 17, 2018

util: make TextEncoder/TextDecoder global #22281

util: make TextEncoder/TextDecoder global #22281

Conversation

jasnell commented Aug 12, 2018

Checklist

nodejs-github-bot commented Aug 12, 2018

vsemozhetbyt Aug 12, 2018

Choose a reason for hiding this comment

vsemozhetbyt Aug 12, 2018

Choose a reason for hiding this comment

vsemozhetbyt commented Aug 12, 2018

jasnell commented Aug 12, 2018

TimothyGu left a comment

Choose a reason for hiding this comment

TimothyGu Aug 12, 2018

Choose a reason for hiding this comment

jasnell Aug 15, 2018

Choose a reason for hiding this comment

BridgeAR left a comment

Choose a reason for hiding this comment

BridgeAR Aug 13, 2018

Choose a reason for hiding this comment

jasnell commented Aug 15, 2018

mcollina left a comment

Choose a reason for hiding this comment

jasnell commented Sep 10, 2018

jasnell commented Sep 12, 2018

jasnell commented Sep 12, 2018

mcollina commented Sep 12, 2018

mcollina left a comment

Choose a reason for hiding this comment

trivikr commented Sep 15, 2018 • edited Loading

mcollina commented Sep 17, 2018

addaleax commented Sep 17, 2018

trivikr commented Sep 15, 2018 •

edited

Loading