Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve urlObject.hash documentation #22326

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 14, 2018

@nodejs/documentation @nodejs/url

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

It's an octothorp, but no one knows what that is either so let's just
show the character in the sentence and be done with it.
Remove "consists of" in favor of "is". Use "fragment identifier" instead
of "fragment" and remove quotes.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Aug 14, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 14, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 14, 2018
Trott added a commit to Trott/io.js that referenced this pull request Aug 14, 2018
It's an octothorp, but no one knows what that is either so let's just
show the character in the sentence and be done with it.

PR-URL: nodejs#22326
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Aug 14, 2018
Remove "consists of" in favor of "is". Use "fragment identifier" instead
of "fragment" and remove quotes.

PR-URL: nodejs#22326
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@Trott
Copy link
Member Author

Trott commented Aug 14, 2018

Landed in b002f6e...a091fbe

@Trott Trott closed this Aug 14, 2018
rvagg pushed a commit that referenced this pull request Aug 15, 2018
It's an octothorp, but no one knows what that is either so let's just
show the character in the sentence and be done with it.

PR-URL: #22326
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Bryan English <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 15, 2018
Remove "consists of" in favor of "is". Use "fragment identifier" instead
of "fragment" and remove quotes.

PR-URL: #22326
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@Trott Trott deleted the urlObject-hash branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants