Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: touch tools/doc/node_modules after run #22350

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Aug 16, 2018

Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev danbev added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 16, 2018
@nodejs-github-bot
Copy link
Collaborator

@danbev sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 16, 2018
@danbev
Copy link
Contributor Author

danbev commented Aug 16, 2018

@refack
Copy link
Contributor

refack commented Aug 16, 2018

/CC @nodejs/build-files

@refack refack removed the fast-track PRs that do not need to wait for 48 hours to land. label Aug 16, 2018
@refack
Copy link
Contributor

refack commented Aug 16, 2018

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 17, 2018
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder why the time stamp is not updated after npm install?

Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").
@Trott
Copy link
Member

Trott commented Aug 18, 2018

Rebased (to get the recently-committed fix for a CI gotcha), force-pushed, new CI: https://ci.nodejs.org/job/node-test-pull-request/16557/

@BridgeAR
Copy link
Member

Landed in 104492b 🎉

@BridgeAR BridgeAR closed this Aug 20, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Aug 20, 2018
Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").

PR-URL: nodejs#22350
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Aug 21, 2018
Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").

PR-URL: #22350
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").

PR-URL: #22350
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants