-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: touch tools/doc/node_modules after run #22350
Conversation
@danbev sadly an error occured when I tried to trigger a build :( |
/CC @nodejs/build-files |
Testing with rebase (Ref: nodejs/build#1442 (comment)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I wonder why the time stamp is not updated after npm install
?
Currently, tools/doc/node_modules is not touched after running npm install resulting in npm install being run every time. I missed this while testing commit 88bff82 ("build: make tools/doc/node_modules non-phony").
020bb18
to
8833d8f
Compare
Rebased (to get the recently-committed fix for a CI gotcha), force-pushed, new CI: https://ci.nodejs.org/job/node-test-pull-request/16557/ |
Landed in 104492b 🎉 |
Currently, tools/doc/node_modules is not touched after running npm install resulting in npm install being run every time. I missed this while testing commit 88bff82 ("build: make tools/doc/node_modules non-phony"). PR-URL: nodejs#22350 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Currently, tools/doc/node_modules is not touched after running npm install resulting in npm install being run every time. I missed this while testing commit 88bff82 ("build: make tools/doc/node_modules non-phony"). PR-URL: #22350 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Currently, tools/doc/node_modules is not touched after running npm install resulting in npm install being run every time. I missed this while testing commit 88bff82 ("build: make tools/doc/node_modules non-phony"). PR-URL: #22350 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes