-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: remove es benchmark #22361
Conversation
I'm generally -1 on this but won't block. I use these frequently to test improvements in performance across v8 updates. |
I agree with @jasnell that these benchmarks can still be useful to us. |
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16529/ |
This PR needs a rebase against master to avoid the git failure in the CI. |
@jasnell If you are using this frequently then I guess it is worth keeping - I'd argue these types of benchmarks are better suited to external suites like six-speed but I guess in your case, the benefit is having the performance runner within node and getting the numbers out in a format that is useful to you. |
I'm going to close this given that it is in use. We could revisit it once:
|
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesThese benchmarks compare the performance of ES6 features and their ES5 equivalents. These are testing the javascript engine itself and not node in any way, as far as I can tell. six-speed does a good job testing these things already, and there is a lot of overlap between these two suites. We also have alerts set up for six-speed on the V8 side so we will see any regressions before they make it into node. I'd suggest removing these benchmarks entirely.