Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: move strings to env #22401

Closed
wants to merge 1 commit into from
Closed

perf_hooks: move strings to env #22401

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 19, 2018

Move repeatedly created strings to env

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@jasnell
perf_hooks: move strings to env
f860e0e 
Move repeatedly created strings to env
@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/593/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 19, 2018
mcollina
mcollina approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Aug 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16630/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 21, 2018
@jasnell
Copy link
Member Author

jasnell commented Aug 21, 2018

Unrelated CI failures, resuming: https://ci.nodejs.org/job/node-test-pull-request/16637/

@jasnell
Copy link
Member Author

jasnell commented Aug 21, 2018

Resuming again because more unrelated CI failures: https://ci.nodejs.org/job/node-test-pull-request/16643/

@jasnell
Copy link
Member Author

jasnell commented Aug 22, 2018

Resuming again: https://ci.nodejs.org/job/node-test-pull-request/16660/

@jasnell
Copy link
Member Author

jasnell commented Aug 22, 2018

Re-run CI: https://ci.nodejs.org/job/node-test-pull-request/16664/

jasnell added a commit that referenced this pull request Aug 22, 2018
@jasnell
perf_hooks: move strings to env
588fb05 
Move repeatedly created strings to env

PR-URL: #22401
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Aug 22, 2018

Landed in 588fb05

@jasnell jasnell closed this Aug 22, 2018
targos pushed a commit that referenced this pull request Aug 24, 2018
@jasnell @targos
perf_hooks: move strings to env
6d07bf7 
Move repeatedly created strings to env

PR-URL: #22401
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@jasnell @targos
perf_hooks: move strings to env
107c8c0 
Move repeatedly created strings to env

PR-URL: #22401
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @nodejs-github-bot @mcollina @addaleax @TimothyGu @cjihrig @devsnek @trivikr