Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add GitHub email set up link to COLLABORATOR_GUIDE #22525

Closed
wants to merge 2 commits into from
Closed

doc: add GitHub email set up link to COLLABORATOR_GUIDE #22525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85fa8ee
doc: add GitHub email set up link to COLLABORATOR_GUIDE
lundibundi Aug 25, 2018
847f907
fixup! doc: add GitHub email set up link to COLLABORATOR_GUIDE
lundibundi Aug 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ badge.

For first-time contributors, check if the commit author is the same as the
pull request author, and ask if they have configured their git
username and email to their liking as per [this guide][git-username].
This is to make sure they would be promoted to "contributor" once
their pull request lands.
[username][git-username] and [email][git-email] to their liking.
This is to make sure they would be promoted to "contributor" once their
pull request lands.

### Closing Issues and Pull Requests

Expand Down Expand Up @@ -889,5 +889,6 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
[git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
[git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata
[git-username]: https://help.github.com/articles/setting-your-username-in-git/
[git-email]: https://help.github.com/articles/setting-your-commit-email-address-in-git/
[node-core-utils-credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials
[node-core-utils-issues]: https://github.com/nodejs/node-core-utils/issues