Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,deps: backport and use non-deprecated V8 methods with isolate #22531

Closed
wants to merge 6 commits into from
Closed

src,deps: backport and use non-deprecated V8 methods with isolate #22531

wants to merge 6 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 26, 2018

Follow-up to #22521

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/677/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 26, 2018
@targos
Copy link
Member Author

targos commented Aug 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16781/

@targos
Copy link
Member Author

targos commented Aug 28, 2018

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20331/

@targos
deps: backport StackFrame::GetFrame with isolate
64154c3 
This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5
@targos
src: use StackFrame::GetFrame with isolate
bafe937
@targos
deps: backport String::Write{OneByte,Utf8} with isolate
845bf71 
These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5
@targos
src: use String::Write{OneByte,Utf8} with isolate
85833b1
@targos
deps: backport String::Utf8Length with isolate
761c0a0 
This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f
@targos
src: use String::Utf8Length with isolate
fc0b211
targos added a commit to targos/node that referenced this pull request Aug 29, 2018
@targos
deps: backport StackFrame::GetFrame with isolate
487c1e0 
This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit to targos/node that referenced this pull request Aug 29, 2018
@targos
src: use StackFrame::GetFrame with isolate
30c7946 
PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit to targos/node that referenced this pull request Aug 29, 2018
@targos
deps: backport String::Write{OneByte,Utf8} with isolate
7c84489 
These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit to targos/node that referenced this pull request Aug 29, 2018
@targos
src: use String::Write{OneByte,Utf8} with isolate
a64fd7f 
PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit to targos/node that referenced this pull request Aug 29, 2018
@targos
deps: backport String::Utf8Length with isolate
17dd620 
This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit to targos/node that referenced this pull request Aug 29, 2018
@targos
src: use String::Utf8Length with isolate
b2f0cfa 
PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
Copy link
Member Author

targos commented Aug 29, 2018

Landed in 2584052...b2f0cfa

@targos targos closed this Aug 29, 2018
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Aug 29, 2018
@targos targos deleted the v8-isolate-everywhere branch August 29, 2018 10:39
targos added a commit that referenced this pull request Aug 30, 2018
@targos
deps: backport StackFrame::GetFrame with isolate
fd991cf 
This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Aug 30, 2018
@targos
src: use StackFrame::GetFrame with isolate
a6af5df 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Aug 30, 2018
@targos
deps: backport String::Write{OneByte,Utf8} with isolate
07f06d8 
These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Aug 30, 2018
@targos
src: use String::Write{OneByte,Utf8} with isolate
f0840e3 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Aug 30, 2018
@targos
deps: backport String::Utf8Length with isolate
c261176 
This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Aug 30, 2018
@targos
src: use String::Utf8Length with isolate
1665583 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 3, 2018
@targos
deps: backport StackFrame::GetFrame with isolate
3dc9cfc 
This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 3, 2018
@targos
src: use StackFrame::GetFrame with isolate
9478f29 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 3, 2018
@targos
deps: backport String::Write{OneByte,Utf8} with isolate
d50e1ff 
These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 3, 2018
@targos
src: use String::Write{OneByte,Utf8} with isolate
8375f75 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 3, 2018
@targos
deps: backport String::Utf8Length with isolate
5f44ce8 
This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 3, 2018
@targos
src: use String::Utf8Length with isolate
332b035 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos added a commit that referenced this pull request Sep 6, 2018
@targos
deps: backport StackFrame::GetFrame with isolate
76806e9 
This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 6, 2018
@targos
src: use StackFrame::GetFrame with isolate
9efa76f 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 6, 2018
@targos
deps: backport String::Write{OneByte,Utf8} with isolate
9140edf 
These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 6, 2018
@targos
src: use String::Write{OneByte,Utf8} with isolate
f576425 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 6, 2018
@targos
deps: backport String::Utf8Length with isolate
83343f7 
This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f

PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 6, 2018
@targos
src: use String::Utf8Length with isolate
12f5480 
PR-URL: #22531
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Sep 6, 2018
Closed
Closed
@Flarna Flarna mentioned this pull request Dec 17, 2018
Closed
richardlau added a commit to richardlau/nodereport that referenced this pull request Dec 21, 2018
@richardlau
Fix use of deprecated methods removed in V8 7.0
8486893 
StackFrame::GetFrame(uint32_t index) was deprecated in V8 6.9 and
removed in V8 7.0.

Refs: nodejs/node#22531
Refs: nodejs#116
@richardlau richardlau mentioned this pull request Dec 21, 2018
Merged
richardlau added a commit to richardlau/nodereport that referenced this pull request Jan 22, 2019
@richardlau
Fix use of deprecated methods removed in V8 7.0
26f88d0 
StackFrame::GetFrame(uint32_t index) was deprecated in V8 6.9 and
removed in V8 7.0.

PR-URL: nodejs#119
Refs: nodejs/node#22531
Refs: nodejs#116
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @danbev @jasnell @addaleax @cjihrig