[v10.x backport] src: implement v8::Platform::CallDelayedOnWorkerThread #22567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Aug 28, 2018
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16825/ (@ak239 Just saw your comment in the other thread … it’s generally helpful to post CI links after kicking off CI 🙂) |
targos
approved these changes
Aug 28, 2018
src/node_platform.cc
Outdated
| @@ -53,6 +174,8 @@ void BackgroundTaskRunner::BlockingDrain() { | |||
|
|
|||
| void BackgroundTaskRunner::Shutdown() { | |||
| background_tasks_.Stop(); | |||
| // pending_worker_tasks_.Stop(); | |||
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. Fixes: #22157
|
I removed commented code and restarted CI: https://ci.nodejs.org/job/node-test-pull-request/16826/ (✔️) |
|
Landed in b3dab8c |
addaleax
pushed a commit
that referenced
this pull request
Aug 28, 2018
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. Backport-PR-URL: #22567 PR-URL: #22383 Fixes: #22157 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. Backport-PR-URL: #22567 PR-URL: #22383 Fixes: #22157 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
This method is crucial for Runtime.evaluate protocol command with timeout flag. At least Chrome DevTools frontend uses this method for every execution in console. Backport-PR-URL: #22567 PR-URL: #22383 Fixes: #22157 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is crucial for Runtime.evaluate protocol command with
timeout flag. At least Chrome DevTools frontend uses this method for
every execution in console.
Fixes: #22157
Original PR: #22383
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes