Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-report: meld into core #22712

Merged
merged 3 commits into from
Jan 18, 2019
Merged

node-report: meld into core #22712

merged 3 commits into from
Jan 18, 2019

Commits on Jan 18, 2019

  1. src: merge into core 

    Make node-report part of core runtime because:

1. When enabled, node-report significantly helps root cause various
types of problems, including support issues sent to the various repos
of the Node.js organization.

2. The requirement of explicitly adding the dependency to node-report
in user applications often represents a blocker to adoption.

Major deviation from the module version of the node-report is that the
report is generated in JSON format, as opposed to human readable text.

No new functionalities have been added, changes that are required for
melding it as a built-in capability has been affected on the module
version of node-report (https://github.com/nodejs/node-report)

Co-authored-by: Bidisha Pyne <[email protected]>
Co-authored-by: Howard Hellyer <[email protected]>
Co-authored-by: Jeremiah Senkpiel <[email protected]>
Co-authored-by: Julian Alimin <[email protected]>
Co-authored-by: Lakshmi Swetha Gopireddy <[email protected]>
Co-authored-by: Manusaporn Treerungroj <[email protected]>
Co-authored-by: Michael Dawson <[email protected]>
Co-authored-by: Richard Chamberlain <[email protected]>
Co-authored-by: Richard Lau <[email protected]>
Co-authored-by: Sam Roberts <[email protected]>
Co-authored-by: Vipin Menon <[email protected]>

PR-URL: nodejs#22712
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
    @gireeshpunathil
    gireeshpunathil committed Jan 18, 2019
    1 Configuration menu
    Copy the full SHA
    4f67973 View commit details
    Browse the repository at this point in the history

  2. doc: add node-report documentation 

    a separate section added for node-report at top level
main documentation added to doc/api/report.md
API documentation added to doc/api/process.md

PR-URL: nodejs#22712
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
    @vipinmenon @gireeshpunathil
    vipinmenon authored and gireeshpunathil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    7f4053e View commit details
    Browse the repository at this point in the history

  3. test: add node-report tests 

    One test per each API, so that additional tests in future are modular.
test/common/report.js contain common functions  that tests leverage.

PR-URL: nodejs#22712
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
    @LakshmiSwethaG @gireeshpunathil
    LakshmiSwethaG authored and gireeshpunathil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    55e0ad9 View commit details
    Browse the repository at this point in the history