Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove trace_sync_io_ from env #22726

Closed
wants to merge 1 commit into from
Closed

src: remove trace_sync_io_ from env #22726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/env-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ inline void Environment::set_printed_error(bool value) {
}

inline void Environment::set_trace_sync_io(bool value) {
trace_sync_io_ = value;
options_->trace_sync_io = value;
}

inline bool Environment::abort_on_uncaught_exception() const {
Expand Down
3 changes: 1 addition & 2 deletions src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ Environment::Environment(IsolateData* isolate_data,
tick_info_(context->GetIsolate()),
timer_base_(uv_now(isolate_data->event_loop())),
printed_error_(false),
trace_sync_io_(false),
abort_on_uncaught_exception_(false),
emit_env_nonstring_warning_(true),
makecallback_cntr_(0),
Expand Down Expand Up @@ -351,7 +350,7 @@ void Environment::StopProfilerIdleNotifier() {
}

void Environment::PrintSyncTrace() const {
if (!trace_sync_io_)
if (!options_->trace_sync_io)
return;

HandleScope handle_scope(isolate());
Expand Down
1 change: 0 additions & 1 deletion src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,6 @@ class Environment {
TickInfo tick_info_;
const uint64_t timer_base_;
bool printed_error_;
bool trace_sync_io_;
bool abort_on_uncaught_exception_;
bool emit_env_nonstring_warning_;
size_t makecallback_cntr_;
Expand Down
2 changes: 0 additions & 2 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3051,8 +3051,6 @@ inline int Start(Isolate* isolate, IsolateData* isolate_data,
env.async_hooks()->pop_async_id(1);
}

env.set_trace_sync_io(env.options()->trace_sync_io);

{
SealHandleScope seal(isolate);
bool more;
Expand Down