Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update dmn to 2.0.0 #22733

Closed
wants to merge 1 commit into from
Closed

tools: update dmn to 2.0.0 #22733

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 6, 2018

New version of dmn with better support for case-sensitive file systems.
Use it in the update-* scripts.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
tools: update dmn to 2.0.0
955a8e1 
New version of dmn with better support for case-sensitive file systems.
Use it in the update-* scripts.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 6, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/818/pipeline

@Trott
Copy link
Member Author

Trott commented Sep 6, 2018

@silverwind @BridgeAR

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 6, 2018
@Trott
Copy link
Member Author

Trott commented Sep 6, 2018

👍 here for fast-tracking.

@Trott
Copy link
Member Author

Trott commented Sep 6, 2018

This code is not exercised in CI, so the lite CI should be sufficient.

@Trott
Copy link
Member Author

Trott commented Sep 6, 2018

Landed in 7a50dba

@Trott Trott closed this Sep 6, 2018
Trott added a commit to Trott/io.js that referenced this pull request Sep 6, 2018
@Trott
tools: update dmn to 2.0.0
7a50dba 
New version of dmn with better support for case-sensitive file systems.
Use it in the update-* scripts.

PR-URL: nodejs#22733
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2018
@Trott @targos
tools: update dmn to 2.0.0
ca06e65 
New version of dmn with better support for case-sensitive file systems.
Use it in the update-* scripts.

PR-URL: #22733
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request Sep 18, 2018
Merged
@Trott Trott deleted the update-update-node branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @silverwind @targos @cjihrig @richardlau @BridgeAR