-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm: update source, related basic & cached data tests for ArrayBuffer #22921
Closed
Commits on Oct 31, 2018
-
vm: update source, related basic & cached data tests for ArrayBuffer
In vm module, accept ArrayBuffer in place of Uint8Array in the source code & related test code in "test-vm-basic.js" & "test-vm-cached-data.js", per the "vm" item in the checklist of the comment in #1826. Refs: #1826 (comment)
Configuration menu - View commit details
-
Copy full SHA for 0733f4a - Browse repository at this point
Copy the full SHA 0733f4aView commit details -
Use ArrayBufferView/IsArrayBufferView in places of Uint8Array/IsUint8Array, in the node_contextify.cc source code. Refs: #22921 (comment)
Configuration menu - View commit details
-
Copy full SHA for 8029352 - Browse repository at this point
Copy the full SHA 8029352View commit details -
doc: update vm.md for "cachedData" w. TypedArray|DataView
Update the "cachedData" description with support of TypedArray or DataView support in “new vm.Script” & “vm.compileFunction”.
Configuration menu - View commit details
-
Copy full SHA for 2010cfd - Browse repository at this point
Copy the full SHA 2010cfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08d177f - Browse repository at this point
Copy the full SHA 08d177fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc53ec5 - Browse repository at this point
Copy the full SHA bc53ec5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18b86aa - Browse repository at this point
Copy the full SHA 18b86aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b86151e - Browse repository at this point
Copy the full SHA b86151eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 862c63d - Browse repository at this point
Copy the full SHA 862c63dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fac59e7 - Browse repository at this point
Copy the full SHA fac59e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f20aca - Browse repository at this point
Copy the full SHA 0f20acaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.