-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: make config verbose on CI #22935
Conversation
Ohh sorry I created the branch on this repo. I'm hoping to fast track this, so we won't miss information in CI. /CC @nodejs/build-files |
@@ -179,6 +179,7 @@ if defined i18n_arg set configure_flags=%configure_flags% --with-intl=%i | |||
if defined config_flags set configure_flags=%configure_flags% %config_flags% | |||
if defined target_arch set configure_flags=%configure_flags% --dest-cpu=%target_arch% | |||
if defined openssl_no_asm set configure_flags=%configure_flags% --openssl-no-asm | |||
if defined DEBUG_HELPER set configure_flags=%configure_flags% --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this set on the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now ;)
From a windows machine:
From a POSIX machine:
|
For reference, this restores verbose output from |
PR-URL: #22935 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
9fe3d1a
to
c55ebd8
Compare
landed in c55ebd8 |
PR-URL: #22935 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes