Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace deprecated uses of FunctionTemplate::GetFunction #22993

Closed
wants to merge 1 commit into from
Closed

src: replace deprecated uses of FunctionTemplate::GetFunction #22993

wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

Refs: v8@70d60c4

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@hashseed build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/956/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Sep 21, 2018
@hashseed
Copy link
Member Author

This was originally created by @gahaas and committed downstream.

@targos
Copy link
Member

targos commented Sep 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17353/

joyeecheung
joyeecheung approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FunctionTemplate here all seem to come from us so it should be safe to just do ToLocalChecked.

@hashseed
Copy link
Member Author

Using ToLocalChecked is not worse than existing code, which would return an empty handle in equivalent cases and crash elsewhere.

@danbev
Copy link
Contributor

danbev commented Sep 24, 2018

Landed in 7dde560.

@danbev danbev closed this Sep 24, 2018
danbev pushed a commit that referenced this pull request Sep 24, 2018
@gahaas @danbev
src: replace deprecated uses of FunctionTemplate::GetFunction
7dde560 
PR-URL: #22993
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@hashseed
Copy link
Member Author

Thanks for landing this!

targos pushed a commit that referenced this pull request Sep 24, 2018
@gahaas @targos
src: replace deprecated uses of FunctionTemplate::GetFunction
76453f1 
PR-URL: #22993
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
@hashseed hashseed deleted the getfunction branch January 28, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.