Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve reliability of test-gc-net-timeout #23086

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 25, 2018

test-gc-net-timeout is resource-intensive. It times out a lot on CI.
Move to sequential.

Fixes: #23067

Labeling fast-track to fix flaky CI and because this is awfully easy to undo if someone comes up with a better solution. Please 👍 to approve fast-tracking.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test-gc-net-timeout is resource-intensive. It times out a lot on CI.
Move to sequential.

Fixes: nodejs#23067
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 25, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 25, 2018
@Trott
Copy link
Member Author

Trott commented Sep 25, 2018

@addaleax addaleax added the net Issues and PRs related to the net subsystem. label Sep 25, 2018
@danbev
Copy link
Contributor

danbev commented Sep 26, 2018

Landed in 44d2d17.

@danbev danbev closed this Sep 26, 2018
danbev pushed a commit that referenced this pull request Sep 26, 2018
test-gc-net-timeout is resource-intensive. It times out a lot on CI.
Move to sequential.

Approved to be fast-tracked by:
Anna Henningsen <[email protected]>
Daniel Bevenius <[email protected]>

PR-URL: #23086
Fixes: #23067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Sep 27, 2018
test-gc-net-timeout is resource-intensive. It times out a lot on CI.
Move to sequential.

Approved to be fast-tracked by:
Anna Henningsen <[email protected]>
Daniel Bevenius <[email protected]>

PR-URL: #23086
Fixes: #23067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott Trott deleted the test-gc-net-timeout branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-gc-net-timeout
5 participants