Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix unreliable test-gc-http-client #23145

Closed
wants to merge 1 commit into from
Closed

test: fix unreliable test-gc-http-client #23145

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 28, 2018 •
edited
Loading

Calling global.gc() in multiple places leads to unreliability. Call it
in the interval only.

Fixes: #22336

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1049/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 28, 2018
@Trott Trott mentioned this pull request Sep 28, 2018
Closed
@Trott
Copy link
Member Author

Trott commented Sep 28, 2018

Would like to fast-track this. 👍 if you approve.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 28, 2018
@Trott
Copy link
Member Author

Trott commented Sep 28, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17497/

@targos
Copy link
Member

targos commented Sep 28, 2018

Does it really fix #23066? It's not modifying the test in question.

@targos
Copy link
Member

targos commented Sep 28, 2018

Please remove the "Fixes:" link from the commit message.

targos
targos previously requested changes Sep 28, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this test is not fixed for me

@addaleax
Copy link
Member

@targos Just to be clear, your red X is about the Fixes: tag, not the diff itself, right? Because I think this is definitely an improvement.

@targos
Copy link
Member

targos commented Sep 28, 2018

After applying this change, I ran: ./tools/test.py --repeat 100 test/sequential/test-gc-http-client.js

The test always fails before the 30th execution.

@targos targos dismissed their stale review September 28, 2018 14:28

might be an improvement, but doesn't fix flakyness

@Trott Trott mentioned this pull request Sep 28, 2018
Closed
@Trott
test: fix unreliable test-gc-http-client
8741af6 
Calling `global.gc()` in multiple places leads to unreliability. Call it
in the interval only.

Fixes: nodejs#22336
@Trott
Copy link
Member Author

Trott commented Sep 28, 2018

Stress test this PR: https://ci.nodejs.org/job/node-stress-single-test/2031/

Stress test master: https://ci.nodejs.org/job/node-stress-single-test/2032/

@Trott
Copy link
Member Author

Trott commented Sep 28, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17498/

@Trott
Copy link
Member Author

Trott commented Sep 28, 2018

Given CI stress test results (8 failures in 1000 runs on master vs. 0 failures in 1000 runs with this PR), I'm inclined to believe that "Fixes:" is correct here, except for @targos reporting that it is still happening locally...

@targos Is there any chance at all that you were testing against master and not this PR or something like that? Can you share a gist of you at least some of your output and also what platform/OS you're on?

@Trott
Copy link
Member Author

Trott commented Sep 28, 2018 •
edited
Loading

ARM rebuild: https://ci.nodejs.org/job/node-test-commit-arm/18818/ ✔️

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21109/ ✔️

@targos
Copy link
Member

targos commented Sep 29, 2018

@Trott

@targos Is there any chance at all that you were testing against master and not this PR or something like that? Can you share a gist of you at least some of your output and also what platform/OS you're on?

I'm certain that I am testing against this PR applied on top of master.
Gist (truncated after 10 runs): https://gist.github.com/targos/2b9fd900456e64a6fd2f7245d9e18125

My platform is Linux (Fedora 28)

If this fixes the issue on CI, I'm not blocking it.

@Trott
Copy link
Member Author

Trott commented Sep 29, 2018

@targos Thanks! Interesting! I think your gist is different than what we're seeing in CI, I think, because Done: always gets up to 300/300 and it's Collected: that stalls. But for you, it looks like Done: stalled... Any chance there's some firewall throttling going on or something like that?

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 30, 2018
@refack
Copy link
Contributor

refack commented Oct 1, 2018

Resume CI (just for good measure): https://ci.nodejs.org/job/node-test-commit/21949/

@Trott
Copy link
Member Author

Trott commented Oct 2, 2018

Windows timed out so will definitely remove the Fixes, just like @targos suggested. (Stress tests showing failures on master and clean runs with this PR were run on AIX.)

ARM rebuild: https://ci.nodejs.org/job/node-test-commit-arm/18888/

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21186/

@Trott
Copy link
Member Author

Trott commented Oct 2, 2018

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21188/

@Trott
Copy link
Member Author

Trott commented Oct 2, 2018

Landed in 87ea0ca

@Trott Trott closed this Oct 2, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 2, 2018
@Trott
test: improve test-gc-http-client
87ea0ca 
Calling `global.gc()` in multiple places leads to unreliability. Call it
in the interval only.

PR-URL: nodejs#23145
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
targos pushed a commit that referenced this pull request Oct 3, 2018
@Trott @targos
test: improve test-gc-http-client
9b30a63 
Calling `global.gc()` in multiple places leads to unreliability. Call it
in the interval only.

PR-URL: #23145
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the fix-23066 branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

@targos targos targos left review comments

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky parallel/test-gc-http-client
9 participants
@Trott @nodejs-github-bot @targos @addaleax @refack @jasnell @thefourtheye @lpinca @trivikr