Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: pass correct context to CompileFunctionInContext in CompileFunction #23206

Closed
wants to merge 1 commit into from
Closed

vm: pass correct context to CompileFunctionInContext in CompileFunction #23206

wants to merge 1 commit into from

Commits on Oct 9, 2018

  1. vm: pass parsing_context to ScriptCompiler::CompileFunctionInContext 

    ContextifyContext::CompileFunction in src/node_contextify.cc
was incorrectly passing the context variable to
ScriptCompiler::CompileFunctionInContext

This meant that the parsingContext option in vm.compileFunction
was not being applied properly to the compiled function.

fixes: nodejs#23194

doc: clarify parsingContext option for vm.compileScript

test: usage of parsingContext in vm.compileFunction
    Dara Hayes committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    3d9d83c View commit details
    Browse the repository at this point in the history