Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: remove node::crypto::CheckResult #23225

Closed
wants to merge 1 commit into from
Closed

crypto: remove node::crypto::CheckResult #23225

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Oct 2, 2018

This enum and its constants are unused within the codebase.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1099/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 2, 2018
@tniessen
Copy link
Member Author

tniessen commented Oct 2, 2018

Seems like it was added in 3beb880 and then became unused when VerifyCallback was changed to always return 1.

@tniessen
Copy link
Member Author

tniessen commented Oct 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17603/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 6, 2018
@danbev
Copy link
Contributor

danbev commented Oct 8, 2018

Landed in 1c75ec2.

@danbev danbev closed this Oct 8, 2018
danbev pushed a commit that referenced this pull request Oct 8, 2018
@tniessen @danbev
crypto: remove node::crypto::CheckResult
1c75ec2 
PR-URL: #23225
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos pushed a commit that referenced this pull request Oct 10, 2018
@tniessen @targos
crypto: remove node::crypto::CheckResult
26c36ef 
PR-URL: #23225
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@targos targos mentioned this pull request Oct 10, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@tniessen @jasnell
crypto: remove node::crypto::CheckResult
c457391 
PR-URL: #23225
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @nodejs-github-bot @danbev @refack @jasnell @thefourtheye @addaleax @cjihrig