Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix broken test #23232

Closed
wants to merge 1 commit into from
Closed

test: fix broken test #23232

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 3, 2018

Alternative to #23231

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1107/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 3, 2018
@cjihrig cjihrig mentioned this pull request Oct 3, 2018
Closed
4 tasks
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 3, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 3, 2018

Possibly related to #23109, by the way.

@Trott
Copy link
Member

Trott commented Oct 3, 2018

👍 here to approve fast-tracking to unbreak CI.

@refack
Copy link
Contributor

refack commented Oct 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17596/

@addaleax
Copy link
Member

addaleax commented Oct 3, 2018

Do we want to wait for a fully green CI? That’s what the rules say but it seems like a good idea to land this asap…

@Trott
Copy link
Member

Trott commented Oct 3, 2018

Rebuild the only red part of the last CI run: https://ci.nodejs.org/job/node-test-commit-linux-containered/7526/

@Trott
Copy link
Member

Trott commented Oct 3, 2018 •
edited
Loading

And again: https://ci.nodejs.org/job/node-test-commit-linux-containered/7527/ ✔️

@danbev
Copy link
Contributor

danbev commented Oct 3, 2018

Landed in 7aeda94.

@danbev danbev closed this Oct 3, 2018
danbev pushed a commit that referenced this pull request Oct 3, 2018
@cjihrig @danbev
test: fix broken test
7aeda94 
Approved for fast-tracking by:
Rich Trott <[email protected]>
Colin Ihrig <[email protected]>
Refael Ackermann <[email protected]>
James M Snell <[email protected]>
Gireesh Punathil <[email protected]>
Anna Henningsen <[email protected]>
Sakthipriyan Vairamani <[email protected]>

PR-URL: #23232
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 3, 2018

Thanks for fixing this right away.

@cjihrig cjihrig deleted the test branch October 3, 2018 12:35
@joyeecheung joyeecheung mentioned this pull request Oct 3, 2018
Closed
@ofrobots ofrobots mentioned this pull request Oct 3, 2018
Closed
2 tasks
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@cjihrig @jasnell
test: fix broken test
52b58a2 
Approved for fast-tracking by:
Rich Trott <[email protected]>
Colin Ihrig <[email protected]>
Refael Ackermann <[email protected]>
James M Snell <[email protected]>
Gireesh Punathil <[email protected]>
Anna Henningsen <[email protected]>
Sakthipriyan Vairamani <[email protected]>

PR-URL: #23232
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.