-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix ICU shrinker and docs #23266
Conversation
This is just a minimal change, doesn't need to wait for ICU 63.1. @refack I'd like to try your comment in |
@srl295 do you know what caused this change in path (just curious) |
I would be happy to help. |
@refack not sure. I looked briefly into it but didn't find anything obvious. |
Landed in a4ffa0c |
f0a9f3d
to
a4ffa0c
Compare
This landed after being open for 3 hours with just one approval (needs two) and without a full CI run (the lite-CI-only is probably OK if the code is not exercised by our test suite). For small changes that don't need to wait the full time, we have a simple and light-weight fast-tracking procedure. There are a few people advocating for getting rid of the wait period and this PR will no doubt be seen by them as a case-in-point of why we should do that. If we are going to have those kinds of rules, it would be great if they were enforced by tooling (e.g., a commit queue). Occasional contributors especially are likely to not be aware of the rules or that there have been changes. |
Also: After-the-fact LGTM. I also endorse fast-tracking this. Feel free to 👍 here to likewise endorse fast-tracking although it's obviously just symbolic at this point. |
- tools: path to ICU datafile moved - docs: configure is now configure.py Fixes: #23245 PR-URL: #23266 Reviewed-By: Refael Ackermann <[email protected]>
Sorry, I thought I had already had 2. (Related: nodejs/node-core-utils#284 )
OK, I need to reread the procedures and the thread, I thought it said I had only a few hours left in which to land the change. I didn't realize it was a minimum! edit Opened a PR to update git-node's message nodejs/node-core-utils#287 Also, I was trying to avoid merge conflicts with documentation in |
@srl295 No worries. This is all a pretty good demonstration of all sorts of problems with our rules (too many of them, too confusing, too many people that have to know about them, not enough enforcement via tools, too many variations, etc.) |
- tools: path to ICU datafile moved - docs: configure is now configure.py Fixes: #23245 PR-URL: #23266 Reviewed-By: Refael Ackermann <[email protected]>
- tools: path to ICU datafile moved - docs: configure is now configure.py Fixes: #23245 PR-URL: #23266 Reviewed-By: Refael Ackermann <[email protected]>
Fixes: #23245
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes