Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update node-lint-md-cli-rollup #23358

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 9, 2018

Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with npm audit. It also updates remark-preset-lint-node to
1.0.3 (from 1.0.2).

@refack This removes the md lint preset stuff from the filesystem and relies on the npm registry. Having it on the file system messed with npm update and npm audit fix and other npm commands I ran trying to work around it. If you'd like to keep it in the repo, I'm happy to restore it that way. This seems simpler to me and (based on the npm issues I just described) more robust. But just give me a quick explanation why you want it the way it was, and I'll restore it!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with `npm audit`. It also updates remark-preset-lint-node to
1.0.3 (from 1.0.2).
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 9, 2018
@Trott
Copy link
Member Author

Trott commented Oct 9, 2018

@refack
Copy link
Contributor

refack commented Oct 10, 2018

This seems simpler to me and (based on the npm issues I just described) more robust.

I vendored it in to reduce the turnaround time on updates to rules (if the files are checked in we can update the rules independently of remark-preset-lint-node), but if the package is mature enough, and it works 🤷‍♂️

@refack
Copy link
Contributor

refack commented Oct 10, 2018

But don't you want to run it (npm run build-node) and checkin lint-md.js?

@Trott
Copy link
Member Author

Trott commented Oct 10, 2018

@refack
Copy link
Contributor

refack commented Oct 10, 2018

BTW: we don't (yet) have a regression test for the tool. I tested it manually, but that might be a nice chore...

@richardlau
Copy link
Member

Just an observation (not blocking this) but this undoes parts of #23302 (13340d4#diff-e511e27e1719c62f08ee48fd97573087). It's not particularly obvious that lint-md.js is generated.

@refack
Copy link
Contributor

refack commented Oct 10, 2018

We could add a preamble to the file... Or Uglify it... Again some interesting chores...

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 11, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with `npm audit`. It also updates remark-preset-lint-node to
1.0.3 (from 1.0.2).

PR-URL: nodejs#23358
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott
Copy link
Member Author

Trott commented Oct 11, 2018

Landed in 54ce229

@Trott Trott closed this Oct 11, 2018
targos pushed a commit that referenced this pull request Oct 12, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with `npm audit`. It also updates remark-preset-lint-node to
1.0.3 (from 1.0.2).

PR-URL: #23358
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with `npm audit`. It also updates remark-preset-lint-node to
1.0.3 (from 1.0.2).

PR-URL: #23358
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with `npm audit`. It also updates remark-preset-lint-node to
1.0.3 (from 1.0.2).

PR-URL: #23358
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with `npm audit`. It also updates remark-preset-lint-node to
1.0.3 (from 1.0.2).

PR-URL: #23358
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
Update node-lint-md-cli-rollup. This silences some minor warnings that
appear with `npm audit`. It also updates remark-preset-lint-node to
1.0.3 (from 1.0.2).

PR-URL: #23358
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
@Trott Trott deleted the update-for-audit branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants