Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix argument order in asserts #23499

Closed
wants to merge 1 commit into from
Closed

test: fix argument order in asserts #23499

wants to merge 1 commit into from

Conversation

CAYdenberg
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@BridgeAR
test: fix argument order in asserts
d11cfd3 
PR-URL: nodejs#23499
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@BridgeAR
test: fix argument order in asserts
af68c55 
PR-URL: nodejs#23499
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

Landed in af68c55 🎉

@CAYdenberg congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
@CAYdenberg
Copy link
Author

This was closed, not merged. Is that your process?

@BridgeAR
Copy link
Member

@CAYdenberg we do not use the github merge button. Instead, we cherry-pick the commits after adding the meta information to the commit.

@refack
Copy link
Contributor

refack commented Oct 15, 2018

This was closed, not merged. Is that your process?

@CAYdenberg yes. In our process we rebase PR changes on master and add some metadata to the commit message. So your change landed as af68c55

If you associate your local git email with GitHub (as per https://help.github.com/articles/setting-your-commit-email-address-on-github/) the commit will be credited to you in GitHub as well as in the git log.

Thank you very much for the contribution 🥇

jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jasnell
test: fix argument order in asserts
ab052af 
PR-URL: #23499
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@addaleax
test: fix argument order in asserts
bcb954f 
PR-URL: #23499
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@MylesBorins
test: fix argument order in asserts
13afb68 
PR-URL: #23499
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rvagg
test: fix argument order in asserts
fd48bcc 
PR-URL: #23499
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@MylesBorins
test: fix argument order in asserts
1eed9ca 
PR-URL: #23499
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@guybedford guybedford guybedford approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@CAYdenberg @BridgeAR @refack @jasnell @guybedford @cjihrig @gireeshpunathil @trivikr @targos @nodejs-github-bot