-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-http2-session-timeout
as flake on ARM
#23639
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
added
test
Issues and PRs related to the tests.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Oct 13, 2018
/CC @nodejs/testing @nodejs/http2 @nodejs/platform-arm |
refack
force-pushed
the
mark-new-flake
branch
from
October 13, 2018 15:36
f5a4120
to
47af82c
Compare
Trott
approved these changes
Oct 13, 2018
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 13, 2018
Landed in 882e022 |
addaleax
pushed a commit
that referenced
this pull request
Oct 13, 2018
PR-URL: #23639 Refs: #20628 Reviewed-By: Rich Trott <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Oct 14, 2018
PR-URL: #23639 Refs: #20628 Reviewed-By: Rich Trott <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
PR-URL: #23639 Refs: #20628 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
PR-URL: #23639 Refs: #20628 Reviewed-By: Rich Trott <[email protected]>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23639 Refs: #20628 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23639 Refs: #20628 Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #20628
Please 👍 to fast-track
CI:
https://ci.nodejs.org/job/node-test-pull-request/17810/https://ci.nodejs.org/job/node-test-pull-request/17812/
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes