Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix missing deprecation assignment #23809

Closed
wants to merge 3 commits into from
Closed

src: fix missing deprecation assignment #23809

wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 21, 2018

Missed the assignment when landing

This needs a fast-track for v11.0.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1328/pipeline

@jasnell jasnell added fast-track PRs that do not need to wait for 48 hours to land. deprecations Issues and PRs related to deprecations. labels Oct 21, 2018
@jasnell
Copy link
Member Author

jasnell commented Oct 21, 2018

Please 👍 to fast-track

@vsemozhetbyt
Copy link
Contributor

Missing Type: Runtime?

vsemozhetbyt
vsemozhetbyt reviewed Oct 21, 2018
View reviewed changes
doc/api/deprecations.md Outdated
@@ -2247,6 +2247,21 @@ Type: Documentation-only (supports [`--pending-deprecation`][])
Directly calling `process.binding('uv').errname(<val>)` is deprecated.
Please make sure to use [`util.getSystemErrorName()`][] instead.

<a id="DEP0120"></a>
### DEP0120: Windows Performance Counter Support
<!--
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Oct 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--
<!-- YAML

Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Oct 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I will fix DEP0119 in another PR with another similar nit).

refack
refack approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 nits fixed

vsemozhetbyt
vsemozhetbyt approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With nits.

@jasnell
Copy link
Member Author

jasnell commented Oct 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18038/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2018
@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 22, 2018
Closed
3 tasks
mcollina
mcollina approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca
lpinca approved these changes Oct 22, 2018
View reviewed changes
doc/api/deprecations.md Outdated Show resolved Hide resolved
@lpinca @jasnell
[Squash] nit
802ab9e 
Co-Authored-By: jasnell <[email protected]>
jasnell added a commit that referenced this pull request Oct 22, 2018
@jasnell
src: fix missing deprecation assignment
7f61b52 
PR-URL: #23809
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Oct 22, 2018

Landed in 7f61b52

@jasnell jasnell closed this Oct 22, 2018
jasnell added a commit that referenced this pull request Oct 22, 2018
@jasnell
src: fix missing deprecation assignment
f0e5afc 
PR-URL: #23809
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@refack refack refack approved these changes

@mcollina mcollina mcollina approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @nodejs-github-bot @vsemozhetbyt @mcollina @refack @lpinca @cjihrig @BridgeAR