Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix compiler warnings #23880

Closed
wants to merge 3 commits into from
Closed

src: fix compiler warnings #23880

wants to merge 3 commits into from

Conversation

addaleax
Copy link
Member

Address a number of compiler warnings I am currently seeing on master.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: include util-inl.h in worker_agent.cc
211e40e 
Otherwise, the compiler complains about a missing definition
for the (inline) `Calloc` function.
@addaleax
src: make model counter in GetCPUInfo() unsigned
107ca53 
This fixes a compiler warning about comparing against
the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant.
@addaleax
src: remove unused variables
7b0396c 
These have been overlooked in 036fbdb.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1370/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. labels Oct 25, 2018
@mmarchini
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18171/

@mmarchini mmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2018
@cjihrig cjihrig mentioned this pull request Oct 26, 2018
Closed
@addaleax
Copy link
Member Author

Landed in 336651b...1b47354

@addaleax addaleax closed this Oct 28, 2018
@addaleax addaleax deleted the fix-warnings branch October 28, 2018 08:55
pull bot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
@addaleax
src: include util-inl.h in worker_agent.cc
1ba10db 
Otherwise, the compiler complains about a missing definition
for the (inline) `Calloc` function.

PR-URL: nodejs#23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
pull bot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
@addaleax
src: make model counter in GetCPUInfo() unsigned
b0089a5 
This fixes a compiler warning about comparing against
the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant.

PR-URL: nodejs#23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
pull bot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
@addaleax
src: remove unused variables
1b47354 
These have been overlooked in 036fbdb.

PR-URL: nodejs#23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
@addaleax @targos
src: include util-inl.h in worker_agent.cc
11e9425 
Otherwise, the compiler complains about a missing definition
for the (inline) `Calloc` function.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
@addaleax @targos
src: make model counter in GetCPUInfo() unsigned
682e06e 
This fixes a compiler warning about comparing against
the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
@addaleax @targos
src: remove unused variables
f5cb83f 
These have been overlooked in 036fbdb.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@targos targos mentioned this pull request Oct 28, 2018
Merged
@refack refack mentioned this pull request Oct 29, 2018
Merged
3 tasks
refack added a commit to refack/node that referenced this pull request Oct 31, 2018
@refack
build: add -Werror=undefined-inline to clang builds
c515e5c 
PR-URL: nodejs#23961
Refs: nodejs#23954
Refs: nodejs#23910
Refs: nodejs#23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds
bd73da0 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@refack @rvagg
build: add -Werror=undefined-inline to clang builds
cb44bd0 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@addaleax @rvagg
src: include util-inl.h in worker_agent.cc
dba003c 
Otherwise, the compiler complains about a missing definition
for the (inline) `Calloc` function.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@addaleax @rvagg
src: remove unused variables
c2fde21 
These have been overlooked in 036fbdb.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@targos
Copy link
Member

targos commented Nov 28, 2018

Oh, I forgot to post a message. I could only cherry-pick two commits from the PR. The third (107ca53) doesn't apply anymore because #24264 is already on v11.x and removes the changed line.

@MylesBorins
Copy link
Contributor

@targos in that case would it be better to add the backported-to label instead, since some of the commits landed?

@targos
Copy link
Member

targos commented Nov 28, 2018

SGTM

MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds
a1b5643 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds
2e83f1e 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@eugeneo eugeneo eugeneo approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mmarchini mmarchini mmarchini approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.