Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: allow 'http_parser' monkey patching again #24006

Closed
wants to merge 2 commits into from
Closed

child_process: allow 'http_parser' monkey patching again #24006

wants to merge 2 commits into from

Commits on Oct 31, 2018

  1. child_process: allow 'http_parser' monkey patching again 

    Lazy load _http_common and HTTPParser so that the 'http_parser' binding
can be monkey patched before any internal modules require it. This also
probably improves startup performance minimally for programs that never
require the HTTP stack.

Fixes: nodejs#23716
Fixes: creationix/http-parser-js#57
    @Jimbly
    Jimbly committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    482e23f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. http_parser: test monkey patchability 

    Test that _http_common is not required before the first line
of user-level code is run, allowing monkey patchability by
modules like http-parser-js.

PR-URL: nodejs#24006
    @Jimbly
    Jimbly committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    f6c03d2 View commit details
    Browse the repository at this point in the history