makefile: added option for http clone of gcovr #24073
Conversation
nodejs-github-bot
added
the
build
|
@nodejs/build-files |
|
I don't think "try git protocol and then switch to https if it takes longer than 20 seconds" is a good approach. I also don't think that |
|
Applied this change, removed /bin/sh: timeout: command not foundIt continued to run, which surprised me but makes sense now looking at the code. |
|
I'd recommend simply switching the URI to https. |
Oh, yeah, that would at least make it consistent wherever |
It will be fine to have one URI for git clone with http . |
Trott
added
the
author ready
|
Landed in 7cefc80 |
PR-URL: nodejs#24073 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #24073 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#24073 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #24073 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #24073 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #24073 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Checklist
make -j4 test(UNIX)