doc: clarify allowed encoding parameter types #24230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
crypto
|
I think keeping the 'output' prefix is helpful in making it more clear that it's about what the function produces and not something to do with the contents of |
|
These links need fixing with this changes: |
|
@mscdex so you suggest |
|
@sam-github I'm fine with either one |
tniessen
approved these changes
Nov 9, 2018
refack
approved these changes
Nov 9, 2018
sam-github
force-pushed
the
fix-sign-encoding-docs
branch
2 times, most recently
from
cbe9b37
to
7380867
Compare
sam-github
changed the title
|
@vsemozhetbyt How did you find those link errors? The markdown linter isn't find them :-(. PTAL, I think I addressed all comments. |
sam-github
force-pushed
the
fix-sign-encoding-docs
branch
from
7380867
to
aef6001
Compare
|
I usually just grep old anchors in the repository for such signature changes) |
This fixes the incorrect enumerations of their possible values, which weren't up to date with the values actually supported. Also renamed two arguments that used "format" when they meant "encoding".
sam-github
force-pushed
the
fix-sign-encoding-docs
branch
from
aef6001
to
1317f15
Compare
|
@vsemozhetbyt is a travis CI build sufficient for doc PRs, or do I need a full jenkins CI? |
|
Sorry, I just know that CI-lite is sufficient, i.e. linux-one + linter. I am not very aware of our different CI flavors. |
|
ci-lite is what I was looking for, thanks. |
vsemozhetbyt
added
the
author ready
|
Landed in 426ca08 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 9, 2018
This fixes the incorrect enumerations of their possible values, which weren't up to date with the values actually supported. Also renamed two arguments that used "format" when they meant "encoding". PR-URL: nodejs#24230 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
This fixes the incorrect enumerations of their possible values, which weren't up to date with the values actually supported. Also renamed two arguments that used "format" when they meant "encoding". PR-URL: #24230 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
This fixes the incorrect enumerations of their possible values, which weren't up to date with the values actually supported. Also renamed two arguments that used "format" when they meant "encoding". PR-URL: nodejs#24230 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
This fixes the incorrect enumerations of their possible values, which weren't up to date with the values actually supported. Also renamed two arguments that used "format" when they meant "encoding". PR-URL: #24230 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code calls them encoding (mostly), and they are the encoding types
supported by Buffer, so call them that. Also fix the incorrect
enumerations of their possible values, which weren't up to date with the
values actually supported.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes