Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update core-validate-commit url #24331

Closed
wants to merge 1 commit into from
Closed

doc: update core-validate-commit url #24331

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Nov 13, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@watilde build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1590/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 13, 2018
@Trott
Copy link
Member

Trott commented Nov 13, 2018

Collaborators, 👍 here for fast-tracking.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 13, 2018
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2018
@danbev
Copy link
Contributor

danbev commented Nov 13, 2018

Landed in 7067572.

@danbev danbev closed this Nov 13, 2018
danbev pushed a commit that referenced this pull request Nov 13, 2018
@watilde @danbev
doc: update core-validate-commit url
7067572 
PR-URL: #24331
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@watilde watilde deleted the feature/doc-cvc-url branch November 13, 2018 08:35
@watilde
Copy link
Member Author

watilde commented Nov 13, 2018

Thank you!

BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@watilde @BridgeAR
doc: update core-validate-commit url
7fc9107 
PR-URL: #24331
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@watilde @kiyomizumia
doc: update core-validate-commit url
99774f9 
PR-URL: nodejs#24331
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@watilde @codebytere
doc: update core-validate-commit url
8a60798 
PR-URL: #24331
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@watilde @nodejs-github-bot @Trott @danbev @refack @cjihrig @richardlau