Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replaced anonymous functions with closuers #24442

Closed
wants to merge 1 commit into from

Conversation

rkp1146
Copy link

@rkp1146 rkp1146 commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@rkp1146 rkp1146 closed this Nov 17, 2018
@targos targos reopened this Nov 17, 2018
@targos
Copy link
Member

targos commented Nov 17, 2018

I suppose it was closed by mistake?

@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Commit message should look like: test: replace anonymous functions with arrow functions

@gireeshpunathil
Copy link
Member

@rkp1146 - your email is not associated with your GitHub account while you pushed the change.
ref: https://github.com/settings/emails
ref: https://help.github.com/articles/setting-your-commit-email-address-on-github/

@gireeshpunathil
Copy link
Member

fast-track? 👍

@gireeshpunathil
Copy link
Member

@gireeshpunathil
Copy link
Member

Resume build CI: https://ci.nodejs.org/job/node-test-commit/23491/

@gireeshpunathil
Copy link
Member

failure in windows-fanned seems unrelated.

Resume CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22620/

@gireeshpunathil
Copy link
Member

the single failure in windows-fanned is unrelated; landing.

03:26:53 not ok 250 parallel/test-http2-client-upload
03:26:53   ---
03:26:53   duration_ms: 0.321
03:26:53   severity: fail
03:26:53   exitcode: 1
03:26:53   stack: |-
03:26:53     events.js:174
03:26:53           throw er; // Unhandled 'error' event
03:26:53           ^
03:26:53     
03:26:53     Error: read ECONNRESET
03:26:53         at TCP.onStreamRead (internal/stream_base_commons.js:139:27)
03:26:53     Emitted 'error' event at:
03:26:53         at emitErrorNT (internal/streams/destroy.js:82:8)
03:26:53         at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
03:26:53         at process.internalTickCallback (internal/process/next_tick.js:72:19)
03:26:53   ...

@gireeshpunathil
Copy link
Member

looks like this changes are already merged through #24420 . @rkp1146 - can you confirm you worked on the assignment that we provided? In either case, looks like some mishandling. Please let me know your interest on working on another PR, thanks!

@Trott Trott closed this Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants