test:favor arrow function in callback #24542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
added
the
code-and-learn
| @@ -23,7 +23,7 @@ | |||
| const common = require('../common'); | |||
| const zlib = require('zlib'); | |||
|
|
|||
| zlib.gzip('hello', common.mustCall(function(err, out) { | |||
| zlib.gzip('hello', common.mustCall((err, out)=> { | |||
There was a problem hiding this comment.
Nit: space is required before arrow to pass the lint test
https://travis-ci.com/nodejs/node/jobs/159977196
There was a problem hiding this comment.
I didn't know that, I've pushed again with the required changes, thanks!
cjihrig
approved these changes
Nov 21, 2018
gireeshpunathil
approved these changes
Nov 21, 2018
|
@Trott @cjihrig @sreepurnajasti any tips on how to make the remaining tests pass? |
|
It should just be a matter of running it again. Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18856/ |
Trott
added
the
author ready
|
Ahh, thanks @cjihrig :D |
|
fast-track? please 👍 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 22, 2018
PR-URL: nodejs#24542 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
Landed in 21522cb. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
PR-URL: #24542 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24542 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
PR-URL: #24542 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24542 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24542 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24542 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes