Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: fix session[kSession] undefined issue #24547

Closed
wants to merge 2 commits into from

Conversation

leeight
Copy link
Contributor

@leeight leeight commented Nov 21, 2018

finishSessionDestroy already done session cleaning up.

Fix: #24546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Nov 21, 2018
@leeight leeight force-pushed the fix-24546 branch 3 times, most recently from d30c6a3 to 1cd1023 Compare November 21, 2018 13:28
@davedoesdev
Copy link
Contributor

@leeight looks good, thanks

test/parallel/test-http2-server-session-destroy.js Outdated Show resolved Hide resolved
leeight and others added 2 commits November 22, 2018 13:31
`finishSessionDestroy` already done session cleaning up.

Fix: nodejs#24546
@oyyd
Copy link
Contributor

oyyd commented Nov 22, 2018

@Trott
Copy link
Member

Trott commented Nov 25, 2018

Landed in 895fe2f

@Trott Trott closed this Nov 25, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 25, 2018
`finishSessionDestroy` session cleanup when already done.

PR-URL: nodejs#24547
Fixes: nodejs#24546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Nov 25, 2018
`finishSessionDestroy` session cleanup when already done.

PR-URL: #24547
Fixes: #24546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
`finishSessionDestroy` session cleanup when already done.

PR-URL: #24547
Fixes: #24546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
davedoesdev added a commit to davedoesdev/centro that referenced this pull request Dec 7, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
`finishSessionDestroy` session cleanup when already done.

PR-URL: nodejs#24547
Fixes: nodejs#24546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
`finishSessionDestroy` session cleanup when already done.

PR-URL: #24547
Fixes: #24546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
`finishSessionDestroy` session cleanup when already done.

PR-URL: #24547
Fixes: #24546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'Symbol(type)' of undefined
9 participants