Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix nits in lib/internal/bootstrap/cache.js #24581

Closed
wants to merge 1 commit into from
Closed

lib: fix nits in lib/internal/bootstrap/cache.js #24581

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
  • Unwrap short lines.
  • Unify comments.
  • Decrease function calls.

@vsemozhetbyt
lib: fix nits in lib/internal/bootstrap/cache.js
534785f 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.
@nodejs-github-bot
Copy link
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1684/pipeline

@vsemozhetbyt vsemozhetbyt added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 23, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Nov 23, 2018 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/18901/ ✔️

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 25, 2018
@vsemozhetbyt @Trott
lib: fix nits in lib/internal/bootstrap/cache.js
14707b6 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: nodejs#24581
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 25, 2018

Landed in 14707b6

@Trott Trott closed this Nov 25, 2018
@vsemozhetbyt vsemozhetbyt deleted the lib-min-func-calls-internal-bootstrap-cache.js branch November 25, 2018 19:27
targos pushed a commit that referenced this pull request Nov 27, 2018
@vsemozhetbyt @targos
lib: fix nits in lib/internal/bootstrap/cache.js
838eecc 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: #24581
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@vsemozhetbyt @rvagg
lib: fix nits in lib/internal/bootstrap/cache.js
35a7646 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: #24581
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@vsemozhetbyt @refack
lib: fix nits in lib/internal/bootstrap/cache.js
1a8ef07 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: nodejs#24581
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@vsemozhetbyt @BethGriggs
lib: fix nits in lib/internal/bootstrap/cache.js
9daf175 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: #24581
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@vsemozhetbyt @rvagg
lib: fix nits in lib/internal/bootstrap/cache.js
de5d2c0 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: #24581
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vsemozhetbyt @nodejs-github-bot @Trott @addaleax @lpinca @cjihrig @trivikr