doc: clarify symlink resolution for __filename #24587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more explicit that symlinks are resolved in `__filename`. Refs: nodejs#22602 (comment)
nodejs-github-bot
added
doc
addaleax
approved these changes
Nov 24, 2018
doc/api/modules.md
Outdated
| @@ -491,8 +491,8 @@ added: v0.0.1 | |||
|
|
|||
| * {string} | |||
|
|
|||
| The file name of the current module. This is the resolved absolute path of the | |||
| current module file. | |||
| The file name of the current module. This is current module file's absolute path | |||
There was a problem hiding this comment.
Just an idea, but I think file could be omitted or moved before path, which might be even clearer?
There was a problem hiding this comment.
So either current module's absolute path or else current module's absolute file path? It's subtle, but I wonder if that might make someone expect __dirname value instead of __filename if a module is loaded or invoked at the directory level (e.g., node . instead of node index.js).
|
One thing this does not mention explicitly is that |
vsemozhetbyt
approved these changes
Nov 24, 2018
cjihrig
approved these changes
Nov 24, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 27, 2018
Make it more explicit that symlinks are resolved in `__filename`. Refs: nodejs#22602 (comment) PR-URL: nodejs#24587 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in bb04a8b |
targos
pushed a commit
that referenced
this pull request
Nov 27, 2018
Make it more explicit that symlinks are resolved in `__filename`. Refs: #22602 (comment) PR-URL: #24587 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Make it more explicit that symlinks are resolved in `__filename`. Refs: #22602 (comment) PR-URL: #24587 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Make it more explicit that symlinks are resolved in `__filename`. Refs: nodejs#22602 (comment) PR-URL: nodejs#24587 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 11, 2019
Make it more explicit that symlinks are resolved in `__filename`. Refs: #22602 (comment) PR-URL: #24587 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Make it more explicit that symlinks are resolved in `__filename`. Refs: #22602 (comment) PR-URL: #24587 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more explicit that symlinks are resolved in
__filename.Refs: #22602 (comment)
/ping @sam-github @Pomax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes