Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix replace anonymous function with arrow function #24627

Closed
wants to merge 1 commit into from
Closed

doc: fix replace anonymous function with arrow function #24627

wants to merge 1 commit into from

Conversation

yuriettys
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 24, 2018
@Leko Leko added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
oyyd
oyyd approved these changes Nov 24, 2018
View reviewed changes
Copy link
Contributor

@oyyd oyyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to change the commit message from fix replace.. to replace..

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1692/

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 24, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 6e4502c (with commit title nit edited).
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Nov 24, 2018
@yuriettys @vsemozhetbyt
doc: replace anonymous function with arrow function
6e4502c 
PR-URL: #24627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
targos pushed a commit that referenced this pull request Nov 24, 2018
@yuriettys @targos
doc: replace anonymous function with arrow function
e6dd0bb 
PR-URL: #24627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@yuriettys @rvagg
doc: replace anonymous function with arrow function
f80e7a1 
PR-URL: #24627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@yuriettys @refack
doc: replace anonymous function with arrow function
f02cd85 
PR-URL: nodejs#24627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@yuriettys @BethGriggs
doc: replace anonymous function with arrow function
2831727 
PR-URL: #24627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@yuriettys @rvagg
doc: replace anonymous function with arrow function
12ee805 
PR-URL: #24627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@oyyd oyyd oyyd approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yuriettys @vsemozhetbyt @addaleax @oyyd @gireeshpunathil @Leko @BethGriggs @nodejs-github-bot