tools: check for git tag before promoting release #24670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
added
build
|
@rvagg sadly an error occured when I tried to trigger a build :( |
rvagg
force-pushed
the
rvagg/release_script_check_tag_before_promotion
branch
from
d861f54
to
e59f387
Compare
danbev
approved these changes
Nov 28, 2018
|
Used this plus #24669 for all 4 releases today, worked well |
jasnell
approved these changes
Nov 30, 2018
Trott
added
the
author ready
|
Landed in 84c2157 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 1, 2018
PR-URL: nodejs#24670 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
PR-URL: #24670 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24670 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24670 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
rvagg
added a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24670 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can promote a release and then have signing fail because it finds you have no tag for that release or the tag isn't yours. Instead, do the check up-front and fail early to avoid mistakes.
@nodejs/releasers @nodejs/build