test: replace anonymous functions with arrows #24691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhamurkade
force-pushed
the
jsarrow59
branch
from
b04546f
to
b5a8c7f
Compare
Shubhamurkade
force-pushed
the
jsarrow59
branch
from
c768049
to
ee74c81
Compare
|
CI build says that the first commit doesn't follow the guidelines. I've followed all the guidelines but not sure what I missed here. Could anybody please help me on this? |
cjihrig
approved these changes
Nov 28, 2018
Trott
approved these changes
Nov 30, 2018
Trott
added
the
author ready
gireeshpunathil
approved these changes
Nov 30, 2018
|
Landed in 01c5c16 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 30, 2018
PR-URL: nodejs#24691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
PR-URL: #24691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the file test-net-persistent-ref-unref.js to replace anonymous closure functions with arrow functions.