test: fix common.isAlive()
#24756
Closed
test: fix common.isAlive()
#24756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use signal value `0` rather than `'SIGCONT'` as the latter appears to behave unexpectedly on Alpine 3.8. Fixes: nodejs#22308
Trott
added
wip
richardlau
reviewed
Nov 30, 2018
| @@ -460,7 +460,7 @@ function busyLoop(time) { | |||
|
|
|||
| function isAlive(pid) { | |||
| try { | |||
| process.kill(pid, 'SIGCONT'); | |||
| process.kill(pid, 0); | |||
There was a problem hiding this comment.
I'm not convinced this is likely to be the cause unless the tests in question are also using SIGSTOP. process.kill is asynchronous and should only throw if the pid (which appears to be the intention for isAlive()) or signal is invalid.
There was a problem hiding this comment.
Yeah, I'm kind of flinging this against the wall to see if it works. (And CI came back and it didn't work.)
There was a problem hiding this comment.
I haven't read the context here, but I can confirm that 0 is the correct signal to use to check for process existence, and it is has specific support for this purpose on Windows:
node/deps/uv/src/win/process.c
Line 1219 in 01c5c16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use signal value
0rather than'SIGCONT'as the latter appears tobehave unexpectedly on Alpine 3.8.
Fixes: #22308
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes