Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: prepare tools/icu/icutrim.py for Python 3 #24888

Closed
wants to merge 1 commit into from
Closed

tools: prepare tools/icu/icutrim.py for Python 3 #24888

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 7, 2018 •
edited
Loading

  • reload() was moved and sys.setdefaultencoding() was removed in Python 3 because the default encoding is already utf-8
  • use isinstance() instead of directly comparing types as recommended in PEP8
  • use basestring instead of str and unicode as is the Python 2 convention
  • define basestring in Python 3 where it has been removed because all str are Unicode.
  • run isort on the imports for readability
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Dec 7, 2018
@Trott
Copy link
Member

Trott commented Dec 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19311/

@Trott
Copy link
Member

Trott commented Dec 10, 2018 •
edited
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19373/ ✔️

@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Dec 10, 2018
@Trott
Copy link
Member

Trott commented Dec 10, 2018

@nodejs/python This could use another review.

@Trott
Copy link
Member

Trott commented Dec 10, 2018

Landed in a91293d

@Trott Trott closed this Dec 10, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 10, 2018
@Trott
tools: prepare tools/icu/icutrim.py for Python 3
a91293d 
PR-URL: nodejs#24888
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@cclauss cclauss deleted the Py3-for-tools-icu branch December 10, 2018 16:52
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@BethGriggs
tools: prepare tools/icu/icutrim.py for Python 3
1f61c89 
PR-URL: #24888
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
tools: prepare tools/icu/icutrim.py for Python 3
926d391 
PR-URL: nodejs#24888
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
tools: prepare tools/icu/icutrim.py for Python 3
91a96e4 
PR-URL: #24888
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BethGriggs
tools: prepare tools/icu/icutrim.py for Python 3
6750ceb 
PR-URL: #24888
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
tools: prepare tools/icu/icutrim.py for Python 3
4358812 
PR-URL: #24888
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Assignees
No one assigned
Labels
i18n-api Issues and PRs related to the i18n implementation. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cclauss @Trott @thefourtheye @BethGriggs @nodejs-github-bot