process: move process.features initialization into node.js #25239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
joyeecheung
force-pushed
the
port-features
branch
from
277a2ea
to
a7f3f89
Compare
Use `internalBinding('config')` to shim the legacy
`process.features`.
joyeecheung
force-pushed
the
port-features
branch
from
a7f3f89
to
bc1ceb8
Compare
joyeecheung
commented
Dec 27, 2018
| debug: isDebugBuild, | ||
| uv: true, | ||
| ipv6: true, // TODO(bnoordhuis) ping libuv | ||
| tls_alpn: hasOpenSSL, |
There was a problem hiding this comment.
This should also be available as process.versions.openssl even though that's not the purpose of that property - I wonder if we should just use that instead?
addaleax
approved these changes
Dec 27, 2018
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19835/ ✔️ |
addaleax
added
process
jasnell
approved these changes
Dec 27, 2018
JungMinu
approved these changes
Dec 28, 2018
|
Landed in 39a2ac4 |
addaleax
pushed a commit
that referenced
this pull request
Dec 31, 2018
Use `internalBinding('config')` to shim the legacy
`process.features`.
PR-URL: #25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
|
Should this be backported to |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Use `internalBinding('config')` to shim the legacy
`process.features`.
PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
|
This applies cleanly now :) |
addaleax
pushed a commit
that referenced
this pull request
Jan 15, 2019
Use `internalBinding('config')` to shim the legacy
`process.features`.
PR-URL: #25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Use `internalBinding('config')` to shim the legacy
`process.features`.
PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 17, 2019
Use `internalBinding('config')` to shim the legacy
`process.features`.
PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
internalBinding('config')to shim the legacyprocess.features.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes