Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x] backport of #25105, #25149 and #25150 #25406

Closed
wants to merge 3 commits into from
Closed

[v11.x] backport of #25105, #25149 and #25150 #25406

wants to merge 3 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Jan 9, 2019

Backport of #25105, #25149 and #25150.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
lib: remove internal util._extends() usage
3875a7a 
This removes all internal calls to the deprecated `_extends()`
function. It is slower than `Object.assign()` and the object spread
notation since V8 6.8 and using the spread notation often also
results in shorter code.

PR-URL: nodejs#25105
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR
lib: expose all type checks from the internal types module
4788625 
Combine all type checks on the internal types module and do not use
the types binding anywhere else anymore. This makes sure all of those
checks exist when required.

PR-URL: nodejs#25149
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR
buffer: inspect extra properties
6e18384 
This makes sure extra properties on buffers are not ignored anymore
when inspecting the buffer.

PR-URL: nodejs#25150
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2194/pipeline

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v11.x labels Jan 9, 2019
@BridgeAR
Copy link
Member Author

BridgeAR commented Jan 9, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/20014/

@BridgeAR
Copy link
Member Author

BridgeAR commented Jan 9, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/20034/

@BridgeAR
Copy link
Member Author

BridgeAR commented Jan 9, 2019

@nodejs/releasers @nodejs/util @nodejs/buffer PTAL

@BridgeAR
Copy link
Member Author

Landed in dc4e5c5...95fa3c7

@BridgeAR BridgeAR closed this Jan 10, 2019
@BridgeAR BridgeAR deleted the backport-more-things-to-11 branch January 20, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BridgeAR @nodejs-github-bot