Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,worker_threads: simplify common.isMainThread #25426

Closed
wants to merge 1 commit into from
Closed

test,worker_threads: simplify common.isMainThread #25426

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 9, 2019

Now that worker_threads do not require a flag, the logic around
loading isMainThread can be removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test,worker_threads: simplify common.isMainThread
cba1781 
Now that `worker_threads` do not require a flag, the logic around
loading `isMainThread` can be removed.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2215/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 9, 2019
@Trott
Copy link
Member Author

Trott commented Jan 9, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20039/ ✅

@richardlau
Copy link
Member

Is there a case for removing this from common entirely now and directly calling require('worker_threads').isMainThread from the tests?

@Trott
Copy link
Member Author

Trott commented Jan 10, 2019

Is there a case for removing this from common entirely now and directly calling require('worker_threads').isMainThread from the tests?

@richardlau Yes, probably, but that will be a larger change with more churn that will be more likely to have merge conflicts on backporting etc. So I was thinking: Do this narrower change first.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 11, 2019
@Trott
Copy link
Member Author

Trott commented Jan 12, 2019

Landed in 9e62bb5

@Trott Trott closed this Jan 12, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 12, 2019
@Trott
test,worker: simplify common.isMainThread
9e62bb5 
Now that `worker_threads` do not require a flag, the logic around
loading `isMainThread` can be removed.

PR-URL: nodejs#25426
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@Trott @addaleax
test,worker: simplify common.isMainThread
a29adef 
Now that `worker_threads` do not require a flag, the logic around
loading `isMainThread` can be removed.

PR-URL: #25426
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott @BridgeAR
test,worker: simplify common.isMainThread
e12d056 
Now that `worker_threads` do not require a flag, the logic around
loading `isMainThread` can be removed.

PR-URL: nodejs#25426
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@Trott Trott deleted the my-main-thread branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @richardlau @eugeneo @cjihrig @BridgeAR