Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: make ClientRequest#setTimeout() a no-op after end #25536

Closed
wants to merge 1 commit into from
Closed

http: make ClientRequest#setTimeout() a no-op after end #25536

wants to merge 1 commit into from

Conversation

timdp
Copy link
Contributor

@timdp timdp commented Jan 16, 2019 •
edited
Loading

Fixes: #25499

Originally discovered and resolved by @szmarczak

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jan 16, 2019
@timdp timdp mentioned this pull request Jan 16, 2019
Closed
@lpinca
Copy link
Member

lpinca commented Jan 17, 2019 •
edited by danbev
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20185/ (✔️ )

@danbev
Copy link
Contributor

danbev commented Jan 22, 2019

Landed in 1b11824.

@danbev danbev closed this Jan 22, 2019
danbev pushed a commit that referenced this pull request Jan 22, 2019
@timdp @danbev
http: make ClientRequest#setTimeout() noop at end
1b11824 
Originally discovered and resolved by @szmarczak.

PR-URL: #25536
Fixes: #25499
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@szmarczak szmarczak mentioned this pull request Jan 22, 2019
Merged
addaleax pushed a commit that referenced this pull request Jan 23, 2019
@timdp @addaleax
http: make ClientRequest#setTimeout() noop at end
d6b50c6 
Originally discovered and resolved by @szmarczak.

PR-URL: #25536
Fixes: #25499
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@timdp @BethGriggs
http: make ClientRequest#setTimeout() noop at end
e842dcc 
Originally discovered and resolved by @szmarczak.

PR-URL: #25536
Fixes: #25499
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@timdp @BethGriggs
http: make ClientRequest#setTimeout() noop at end
d30ea03 
Originally discovered and resolved by @szmarczak.

PR-URL: #25536
Fixes: #25499
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@timdp @MylesBorins
http: make ClientRequest#setTimeout() noop at end
ced7f67 
Originally discovered and resolved by @szmarczak.

PR-URL: #25536
Fixes: #25499
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak left review comments

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP request setTimeout(0) does not remove timeout listener
6 participants
@timdp @lpinca @danbev @jasnell @szmarczak @nodejs-github-bot