Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: running coverage for individual suites #25622

Closed
wants to merge 1 commit into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 21, 2019

follow up from d1dee49, adding @thefourtheye's documentation request.

Checklist

@bcoe bcoe added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 21, 2019
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 21, 2019
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcoe
Copy link
Contributor Author

bcoe commented Jan 22, 2019

@vsemozhetbyt added the additional ticks, also noticed the paragraph below was a bit redundant and reworded.

If folks are alright with this pass at the documentation, I'm advocating this doc change is probably okay to fast track.

@bcoe
Copy link
Contributor Author

bcoe commented Jan 22, 2019

@bcoe
Copy link
Contributor Author

bcoe commented Jan 23, 2019

Landed in 885b3bc

@bcoe bcoe closed this Jan 23, 2019
@bcoe bcoe deleted the run-isolated-suites branch January 23, 2019 01:23
bcoe added a commit to bcoe/node-1 that referenced this pull request Jan 23, 2019
PR-URL: nodejs#25622
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@bcoe
Copy link
Contributor Author

bcoe commented Jan 23, 2019

Landed in e3f917e

addaleax pushed a commit that referenced this pull request Jan 23, 2019
PR-URL: #25622
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants