Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document uniqueness of worker.threadId #25644

Closed
wants to merge 1 commit into from
Closed

doc: document uniqueness of worker.threadId #25644

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

/cc @SimenB

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2343/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 22, 2019
@addaleax addaleax added the worker Issues and PRs related to Worker support. label Jan 22, 2019
@SimenB
Copy link
Member

SimenB commented Jan 22, 2019

Thanks for the clarification!

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2019
@danbev
Copy link
Contributor

danbev commented Jan 29, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20404/

@danbev
Copy link
Contributor

danbev commented Jan 29, 2019

Landed in 25e057e.

@danbev danbev closed this Jan 29, 2019
danbev pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @danbev
doc: document uniqueness of worker.threadId
25e057e 
PR-URL: #25644
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @targos
doc: document uniqueness of worker.threadId
c56ddc7 
PR-URL: #25644
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB left review comments

@danbev danbev danbev approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @SimenB @danbev @cjihrig