Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add documentation for request.path #25788

Closed
wants to merge 3 commits into from
Closed

doc: add documentation for request.path #25788

wants to merge 3 commits into from

Conversation

gjbkz
Copy link
Contributor

@gjbkz gjbkz commented Jan 29, 2019

The field has been added in v0.4.0.

Refs: b09c588#diff-1c0f1c434b17b7f8795d44a51a14320aR814
Refs: /test/parallel/test-http-client-defaults.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

I ran make -j4 test on macOS. But I got the message below:

=== release test-fs-stat-bigint ===                                           
Path: parallel/test-fs-stat-bigint
(node:95776) ExperimentalWarning: The fs.promises API is experimental
assert.js:351
    throw err;
    ^

AssertionError [ERR_ASSERTION]: atimeMs is not a safe integer, difference should < 1.
Number version 1548759595527.3901, BigInt version 1548759595525n
    at verifyStats (/Users/itok/node/test/parallel/test-fs-stat-bigint.js:72:7)
    at fs.stat (/Users/itok/node/test/parallel/test-fs-stat-bigint.js:109:7)
    at FSReqCallback.oncomplete (fs.js:160:5)
Command: out/Release/node /Users/itok/node/test/parallel/test-fs-stat-bigint.js
[04:35|% 100|+ 2518|-   1]: Done
make[1]: *** [jstest] Error 1
make: *** [test] Error 2

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jan 29, 2019
@vsemozhetbyt

This comment has been minimized.

doc/api/http.md Outdated Show resolved Hide resolved
@gjbkz
Copy link
Contributor Author

gjbkz commented Jan 30, 2019

I added the commit and edited the description as I noticed that v0.3.6 didn't expose request.path.

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt
Copy link
Contributor

Landed in 32c7ad6
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants