Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve doc on unintended breaking changes #25887

Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 2, 2019

Improve the material in the Collaborator Guide on unintended breaking
changes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Improve the material in the Collaborator Guide on unintended breaking
changes.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 2, 2019
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Feb 2, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2019
@Trott
Copy link
Member Author

Trott commented Feb 4, 2019

Landed in 3fe9267

@Trott Trott closed this Feb 4, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 4, 2019
Improve the material in the Collaborator Guide on unintended breaking
changes.

PR-URL: nodejs#25887
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
Improve the material in the Collaborator Guide on unintended breaking
changes.

PR-URL: #25887
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
@Trott Trott deleted the improve-unintended-breaking-changes branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants