Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: extract common sockaddr creation code #26070

Closed
wants to merge 4 commits into from
Closed

src: extract common sockaddr creation code #26070

wants to merge 4 commits into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Feb 13, 2019

This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: extract common sockaddr creation code
db1028c 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.
@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2590/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. labels Feb 13, 2019
@danbev
Copy link
Contributor Author

danbev commented Feb 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20758/

@danbev danbev added the wip Issues and PRs that are still a work in progress. label Feb 13, 2019
addaleax
addaleax reviewed Feb 13, 2019
View reviewed changes
src/udp_wrap.cc Outdated Show resolved Hide resolved
@danbev
Copy link
Contributor Author

danbev commented Feb 13, 2019

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/20759/

addaleax
addaleax approved these changes Feb 13, 2019
View reviewed changes
src/udp_wrap.cc Outdated Show resolved Hide resolved
@danbev danbev removed the wip Issues and PRs that are still a work in progress. label Feb 14, 2019
richardlau
richardlau reviewed Feb 14, 2019
View reviewed changes
src/udp_wrap.cc Outdated Show resolved Hide resolved
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20806/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 15, 2019
@antsmartian
Copy link
Contributor

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20826/

@addaleax
Copy link
Member

Landed in 05292cb

@addaleax addaleax closed this Feb 17, 2019
addaleax pushed a commit that referenced this pull request Feb 17, 2019
@danbev @addaleax
src: extract common sockaddr creation code
05292cb 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 17, 2019
@danbev @addaleax
src: extract common sockaddr creation code
e13ce0f 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danbev danbev deleted the udp_sockaddr branch February 25, 2019 06:36
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@danbev @rvagg
src: extract common sockaddr creation code
f44f335 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@danbev @MylesBorins
src: extract common sockaddr creation code
89dd890 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@danbev @MylesBorins
src: extract common sockaddr creation code
57469e6 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 16, 2019
Merged
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danbev @nodejs-github-bot @addaleax @antsmartian @jasnell @richardlau