Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise deprecation level explanations in Collaborator Guide #26197

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 19, 2019

Revise deprecation level explanations for scanability and ease of
understanding.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Revise deprecation level explanations for scanability and ease of
understanding.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 19, 2019
@vsemozhetbyt vsemozhetbyt added deprecations Issues and PRs related to deprecations. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 19, 2019
* End-of-life
* The API is no longer subject to the semantic versioning rules.
* Backward-incompatible changes including complete removal of such APIs may
occur at any time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion: should be state that End-of-life mostly means it is removed?

@Trott
Copy link
Member Author

Trott commented Feb 21, 2019

Landed in 70b13c2

@Trott Trott closed this Feb 21, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 21, 2019
Revise deprecation level explanations for scanability and ease of
understanding.

PR-URL: nodejs#26197
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 21, 2019
Revise deprecation level explanations for scanability and ease of
understanding.

PR-URL: #26197
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Revise deprecation level explanations for scanability and ease of
understanding.

PR-URL: #26197
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the deprecation-levels branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants